choojs / bankai

:station: - friendly web compiler
Apache License 2.0
1.09k stars 102 forks source link

πŸ› Update deprecated package `opn` #525

Closed perguth closed 5 years ago

perguth commented 5 years ago

This somewhat of a πŸ› bug fix.

"The package has been renamed to open"


For me updating the dependency also solved the bug where inspect would break because it couldn't open a browser window (thanks @goto-bus-stop for pointing it out ✨).

user@computer ~/software-v2/node $ npm run inspect

> software-v2@1.0.0 inspect /home/user/software-v2/node
> bankai inspect client.js

/tmp/1559101935126.html
(node:2571) UnhandledPromiseRejectionWarning: Error: Exited with code 3
    at ChildProcess.cp.once.code (/home/user/software-v2/node/node_modules/opn/index.js:85:13)
    at Object.onceWrapper (events.js:281:20)
    at ChildProcess.emit (events.js:193:13)
    at maybeClose (internal/child_process.js:999:16)
    at Socket.stream.socket.on (internal/child_process.js:403:11)
    at Socket.emit (events.js:193:13)
    at Pipe._handle.close (net.js:614:12)
(node:2571) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:2571) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Checklist

Context

No related issues.

Semver Changes

Patch.