search

choojs / bankai

:station: - friendly web compiler
Apache License 2.0
1.09k stars 102 forks source link

Update choo #527

Closed tornqvist closed 4 years ago

tornqvist commented 5 years ago

This is a preemptive PR in anticipation of https://github.com/choojs/choo/issues/700.

sholtomaud commented 5 years ago

@tornqvist What's going with the tests? I forked bankai recently from master and just wanted to update the README with some details on documentify, but the tests are not passing.

How can a readme update fail tests??

goto-bus-stop commented 5 years ago

@shotlom the failure on your PR is because of a test bug on windows, don't worry about it

sholtomaud commented 5 years ago

Ok - but does that mean the pull request dies?

tornqvist commented 5 years ago

@shotlom Our PRs are failing for different reasons, and it doesn't means that your PR is dead.

sholtomaud commented 5 years ago

Thanks @tornqvist - I don't understand how I can fork the master prod release branch and then have if fail when merging with no conflicts unless prod release is failing. What have I done wrong here?

tornqvist commented 4 years ago

This should be ready to merge now that choo@7 is published.