search

choojs / choo-umd

🙈 - umd build for choo framework
3 stars 1 forks source link

Greenkeeper not working #4

Open YerkoPalma opened 6 years ago

YerkoPalma commented 6 years ago

Ok, so Grrenkeeper isn't opening any PR. I activated the github bot, not sure if there is anything else to do, not a big user of greenkeeper here haha. So any help on activating the service will be very welcome @choojs/trainspotters

goto-bus-stop commented 6 years ago

Greenkeeper only opens PRs for new versions that break tests, or that don't satisfy the constraints in package.json (so major versions basically). Otherwise it creates a branch, waits for Travis, and delete the branch on success. If its not opening prs, its probably because there were no breaking updates

yoshuawuyts commented 6 years ago

Sounds like we should create a bot of sorts for this, perhaps.

On Tue, Oct 10, 2017 at 12:32 PM Renée Kooi notifications@github.com wrote:

Greenkeeper only opens PRs for new versions that break tests, or that don't satisfy the constraints in package.json (so major versions basically). Otherwise it creates a branch, waits for Travis, and delete the branch on success. If its not opening prs, its probably because there were no breaking updates

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/choojs/choo-umd/issues/4#issuecomment-335531950, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWlejEXUO2JSG6E42AxaUI94O8iXTggks5sq5wjgaJpZM4P0LfW .

yoshuawuyts commented 6 years ago

@YerkoPalma any idea on what we should do?

bcomnes commented 6 years ago

I think removing the ^ range might fix it.

yoshuawuyts commented 6 years ago

@bcomnes interesting — that would force us to publish lots of patch releases, but wouldn't influence people upstream. Not half bad.y

On Fri, Oct 20, 2017 at 6:34 PM Bret Comnes notifications@github.com wrote:

I think removing the ^ range might fix it.

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/choojs/choo-umd/issues/4#issuecomment-338257756, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWlen3bh754B1zbSLWogL0_fx3Y0WUkks5suMuhgaJpZM4P0LfW .

YerkoPalma commented 6 years ago

Patch releases in this module right? not in the main choo module? if that's the case, it is ok to me

bcomnes commented 6 years ago

That or set up pre-publish scripts in choo proper. I know I leaned to a separate repo, but now I'm thinking that might be the cleanest approach than rely on GK which can sometimes be unreliable.

yoshuawuyts commented 6 years ago

Any ideas on what to do next?

YerkoPalma commented 6 years ago

@bcomnes I agree that a pre-publish hook on main choo repo would be a better approach, but I'm not sure if that would affect people doing npm install. Because if someone is using browserify or other bundler I don't think they want to load the umd build too.

goto-bus-stop commented 6 years ago

I also think that it's best to move this into the main choo module. outputting a umd bundle into its dist/ folder on prepublishOnly.