Smooth - Githubissues

choojs / create-choo-app

🚞 - create a fresh choo application

MIT License

181 stars 36 forks source link

Smooth #45

Closed yoshuawuyts closed 6 years ago

yoshuawuyts commented 6 years ago

Some small changes to make new projects a little smoother.

Changes

Made the base commit message less noisy.
Made the base image more neutral, which means it's always ready to be deployed.
Now includes asking for a description of your project; it's nice to not have to go through and change it everywhere on each new project.
Made the page title the same as the project name.
Revamp the main view with instructions on how to use it.
Slightly simplify the 404 view to match the main view.
Enable service workers by default.

Screenshots

2018-02-03-212618_1920x1080

yoshuawuyts commented 6 years ago

Updated!

goto-bus-stop commented 6 years ago

love it 😍

Enable service workers by default.

i think there were pretty good reasons in the past to disable them by default; did anything change? i'm a bit worried about enabling service workers by default in situations where you might have different apps running on the same localhost:8080 address at different times.

goto-bus-stop commented 6 years ago

for reference, create-react-app disables service workers in development envs: https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#offline-first-considerations

yoshuawuyts commented 6 years ago

@goto-bus-stop yeah, we landed the files stuff, and @YerkoPalma has been polishing the repos a bunch recently. Just did like 10 consecutive deploys to test things out, and things seems to be working a-ok!

YerkoPalma commented 6 years ago

IMO service workers should be disabled in development and enabled in production.