search

choojs / nanocomponent-adapters

🔌 - Convert a nanocomponent to a component for your favourite API or library (web components, (p)react, angular)
MIT License
96 stars 17 forks source link

Individually package the adapters #18

Open bcomnes opened 6 years ago

bcomnes commented 6 years ago

It was pointed out in https://github.com/choojs/nanocomponent-adapters/pull/6#issuecomment-359192650 by @alterx that some of these adapters might require heavy dependencies or peer deps. Rather than bundle all those together, we should make each adapter its own repo/module so that people dont have to feel the weight of every adapter.

So... for anyone interested, redo the adapters you are interested in maintaining as a module and we can remove it from this repo, but still reference/export it as a collection since we already have this.

yoshuawuyts commented 6 years ago

Aye, this sounds great!

kareniel commented 6 years ago

I have a repo for an angular.js 1.x adapter over here. How did you imagine the exports from this module would work? Kind of like choo does with bel?

bcomnes commented 6 years ago

I would model it after https://github.com/maxogden/mississippi

emkay commented 6 years ago

I wanted to use nanocomponent-adapters to prototype some components at work, which is primarily an Angular shop and noticed that version 3.0.0 had an empty index.js file in there. Anyways, to test this out I published the angular one as a separate package and saw this issue. Need to fill out README, etc. Happy to add everyone to the repo and give publish access. y'all just ping me if you want it.

https://github.com/emkay/nanocomponent-adapters-angular https://www.npmjs.com/package/nanocomponent-adapters-angular

bcomnes commented 6 years ago

Looks awesome, we should point to it from here.

emkay commented 6 years ago

https://github.com/choojs/nanocomponent-adapters/pull/20 💖