search

choojs / nanocomponent

🚃 - create performant HTML components
https://leaflet.choo.io/
MIT License
366 stars 30 forks source link

write tests #11

Closed yoshuawuyts closed 7 years ago

yoshuawuyts commented 7 years ago

Too much stuff is failing, we need to make sure this lib works as intended

joshgillies commented 7 years ago

@yoshuawuyts do you need a hand with this? I'm trying to get my head around how to fit nanocomponents into our workflow, so knowing the interface is sound would be of great benefit. 👍

yoshuawuyts commented 7 years ago

@joshgillies oh man, having help writing tests would be amazing! - I agree this is critical; it's bitten us on Dat Desktop too (hence the super ad-hoc patches).

For tests I was thinking a combination of tape for Node testing and tape-run for browser testing. Think testing both would be most resilient b/c choo apps tend to be used in both scenarios - reckon that'd work for ya? :sparkles:

joshgillies commented 7 years ago

Hey, haven't forgot about this. As you can tell I've been kicking the tires here a bit over the last few weeks. I think the above approach to testing is sound. Lets aim to run up a branch + PR and iterate on tests there! 🎉

yoshuawuyts commented 7 years ago

Yeah sounds good!

On Thu, Mar 16, 2017 at 2:52 AM Josh Gillies notifications@github.com wrote:

Hey, haven't forgot about this. As you can tell I've been kicking the tires here a bit over the last few weeks. I think the above approach to testing is sound. Lets aim to run up a branch + PR and iterate on tests there! 🎉

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/nanocomponent/issues/11#issuecomment-286934304, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWlelgwKzK03kkBEkSoAw7kIwBSA0qEks5rmJXbgaJpZM4MGLcE .

yoshuawuyts commented 7 years ago

Welll, the example mostly covers it - given we have so few lines of code I think bugs are hard to sneak in. Closing C: