search

choojs / nanohtml

:dragon: HTML template strings for the Browser with support for Server Side Rendering in Node.
MIT License
687 stars 57 forks source link

Fix bool props #132

Closed tornqvist closed 6 years ago

tornqvist commented 6 years ago

Add missing boolean properties and fix SSR boolean prop test.

The test for boolean properties only checks that the property name includes a boolean property key, not that the actual property is a match, start to end. This means that attributes such as aria-selected=${true} and data-selected=${true} would be matched and either removed or have their value replaced with selected.

goto-bus-stop commented 6 years ago

we can pin the bubleify devdep to 1.1.0 for now.