choojs / nanohtml

:dragon: HTML template strings for the Browser with support for Server Side Rendering in Node.

MIT License

686 stars 49 forks source link

Preserve trailing newline whitespace before text nodes #149

Closed JacobEvelyn closed 5 years ago

JacobEvelyn commented 5 years ago

142 was a great start but it didn't quite fix the whitespace issue for me around text nodes. See the test in this PR for an example of a problem I'm running into.

JacobEvelyn commented 5 years ago

Any movement on this @bcomnes ?

bcomnes commented 5 years ago

Not yet. Been moving all week (ca to Utah). I might have some time this week though once I get the truck unloaded.

Otherwise someone else should beat me to it.

Sent from my mobile

On May 28, 2019, at 7:17 AM, Jacob Evelyn notifications@github.com wrote:

Any movement on this @bcomnes ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

JacobEvelyn commented 5 years ago

No worries! Good luck with the move! 🚚

JacobEvelyn commented 5 years ago

This PR is now three months old. @bcomnes any reason not to merge it?

Hope Utah's treating you well!

perguth commented 5 years ago

I think that's in line with what HTML does/a webdev expects. 👍

perguth commented 5 years ago

Funny, I now have a similar problem: I would to render a newline character without using <br> because I am outputting into a <code> block. Having the newlines preserved would be nice ✨

bcomnes commented 5 years ago

Sorry for the delay, this should be going out shortly.