choojs / nanomorph

🚅 - Hyper fast diffing algorithm for real DOM nodes
MIT License
726 stars 58 forks source link

Indeterminate checkbox property #119

Closed mantoni closed 4 years ago

mantoni commented 4 years ago

The HTML living standard defines the indeterminate property for checkboxes. It cannot be set using an HTML attribute though, only through JavaScript. Currently, the choo DOM diffing does not respect this property.

I have added test cases for the checkbox and disabled properties as a separate commit, since I expected them to behave similar to indeterminate. However, attempting to allow setting the property like <input type="checkbox" indeterminate=${false}> does not do the expected thing and would still set the property to true.

Refs:

goto-bus-stop commented 4 years ago

📦 5.4.1