choonghyunryu / alookr

Tools for Binary Classification Modeling
https://choonghyunryu.github.io/alookr/
12 stars 3 forks source link

NOTICE: plan(multiprocess) of future is deprecated #2

Open HenrikBengtsson opened 3 years ago

HenrikBengtsson commented 3 years ago

Hi.

This is a friendly reminder that plan(multiprocess) of the future package is deprecated since future 1.20.0 (2020-11-03). It will eventually become defunct and removed. The background for this can be found in https://github.com/HenrikBengtsson/future/issues/420.

Your alookr package relies on multiprocess, cf. https://github.com/choonghyunryu/alookr/search?q=multiprocess.

Please migrate your code to the platform-independent plan(multisession) or the Linux/macOS-specific plan(multicore). If you want to emulate what multiprocess does, you can do something like:

  if (parallelly::supportsMulticore()) {
    oplan <- plan(multicore)
  } else {
    oplan <- plan(multisession)
  }
  on.exit(plan(oplan))

BTW, if you don't already do so, please make sure to undo any plan() you set in your code, as illustrated by the above example. This is needed to guarantee that calling your code won't override settings that the user has set previously. You can read about this in https://future.futureverse.org/reference/plan.html#for-package-developers.

Thank you!

Henrik (maintainer of the future package)

HenrikBengtsson commented 2 years ago

I see you missed fixing this with your most recent CRAN release on 2022-05-25. Please note that your package will fail R CMD check when the 'multiprocess' is made defunct in future. I would appreciate if you could fix this in your package, because it would save me and the CRAN Team having to explain why reverse package break. Thank you.

choonghyunryu commented 2 years ago

@HenrikBengtsson

Thanks for your notice. I will modify the code to solve the issue.

And thank you for developing future. It is very useful.