choongzhanhong / pe

0 stars 0 forks source link

General Sequence Diagram #12

Open choongzhanhong opened 1 year ago

choongzhanhong commented 1 year ago

Hmm, please correct me if I'm wrong. Here are some comments I have on it:

  1. Are you supposed to write the <<class>> above MoneyMoover and Parser?
  2. The : CreateAccountCommand activation bar, should it be continuous? Also the extra space between the : and the rest in the name.
  3. I believe after printMessage() the :UI should return control to :CreateAccountCommand right?
  4. Should :CreateAccountCommand destroyed after it is done running?
nus-se-bot commented 1 year ago

Team's Response

(1) is rejected because it is how a static method is called.

https://nus-cs2113-ay2223s2.github.io/website/se-book-adapted/chapters/uml.html#calls-to-static-methods

(2) is rejected because the constructor returns before the execute method is called. The extra space is valid but the severity should be very low.

(3) is rejected as it is omitted for simplicity. Void functions do not need a return arrow.

2023-04-16 15.40.53.jpg

(4) is omitted due to simplicity. Since it is a single instance, it can be omitted.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]