added touchscreen support

[jacksonjacobs1]

Added event listeners for touchscreen support.

Touchscreen functionality was tested with the following devices:

• iPad
• Dell precision 7670 touch screen
• Wacom intuos drawing pad

Issues:

QuickAnnotator UI was not developed responsively, thus smaller displays such as iPads and mobile devices may not display correctly. However, support for these devices might be outside of the scope of this project.

[choosehappy]

Don't want to be a naysayer here, but these code changes look very similar to the "window.addEventListener('mousemove', function(event) {" function?

is there a specific requirement as to why these need to be separated, or can these be refactored to use the same set of code?

i mostly worry because this stuff is pretty brittle, and it is unlikely that if we make changes to one section we'll remember to make the same changes to other --- yielding different results from the same actions

thoughts?

[jacksonjacobs1]

That makes sense! I can move the bulk of the code into a helper function which is shared by the touch and mouse event listeners. Would that make sense to you?

[choosehappy]

yup

---

From: Jackson Jacobs @.> Sent: Thursday, August 24, 2023 3:21 PM To: choosehappy/QuickAnnotator @.> Cc: Janowczyk, Andrew R. @.>; Comment @.> Subject: [External] Re: [choosehappy/QuickAnnotator] added touchscreen support (PR #37)

That makes sense! I can move the bulk of the code into a helper function which is shared by the touch and mouse event listeners. Would that make sense to you?

— Reply to this email directly, view it on GitHubhttps://github.com/choosehappy/QuickAnnotator/pull/37#issuecomment-1691665413, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACJ3XTBNKTEMBMZ2ZPMSCOLXW5INLANCNFSM6AAAAAA334TCTM. You are receiving this because you commented.Message ID: @.***>

[choosehappy]

yum!