choowengyan / pe

0 stars 0 forks source link

Allow `add` and `edit` invalid format for phone number #10

Open choowengyan opened 5 months ago

choowengyan commented 5 months ago

As shown in the User Guide, Phone Number must follow the standard Singapore Phone Number with 8-digits. Screenshot 2024-04-19 at 4.55.05 PM.png

However, user is able to add or edit person's phone number to a length which does not follows the standard Singapore Phone Number as shown in the screenshot below. Screenshot 2024-04-19 at 4.58.37 PM.png

Screenshot 2024-04-19 at 4.54.15 PM.png

nus-se-script commented 5 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

PHONE_NUMBER format does not behave as the UG

The UG stated that phone number must follow the standard Singapore telephone numbers (i.e. 9XXXXXXX or 8XXXXXXX). However, adding phone numbers with format different from those mentioned is still allowed.

image.png


[original: nus-cs2103-AY2324S2/pe-interim#4181] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** [I believe that this issue is categorised into Medium. This is because incorrect error message will give a false information to the user and it is not working as what the application is expected to. For example, the user uses the application straight without reading the User Guide and thought that as long as the phone number inserted is more than 3 digits long such as phone number from Malaysia, China or India, would be a valid one. However, the application only serves Singapore Phone Number. Hence, in a scenario where the user need to contact the person in the list, user would not be able to reach out to them as he/she is actually calling people from overseas instead of Singapore. Extra changes may imply and causes a lot of trouble to the user where he/she needs to find the correct way to contact the person once again, it is time consuming and not efficient, which violates the purpose of having this application being able to arrange meetings in faster manner. This has clearly caused **occasional inconvienence** to the user. ![Screenshot 2024-04-23 at 3.26.43 PM.png](https://raw.githubusercontent.com/choowengyan/pe/main/files/7597ddcb-4a81-41de-b087-efe52ebe3494.png) Screenshot taken from team's User Guide: The application supposed to manage meetings in an efficient manner as stated in the User Guide, but given the issue, it will cause a lot of trouble and it does not really help to manage the tasks faster in any manner. ![Screenshot 2024-04-23 at 3.26.00 PM.png](https://raw.githubusercontent.com/choowengyan/pe/main/files/1e1e93f8-b1a2-4251-a484-fb71870952ef.png) ]