choowengyan / pe

0 stars 0 forks source link

Incorrect Error Message for Invalid Phone Number #11

Open choowengyan opened 5 months ago

choowengyan commented 5 months ago

According to the User Guide, the program should follow the Standard Singapore Phone Number with 8 digits. Screenshot 2024-04-19 at 5.01.38 PM.png

As shown in the screenshot below, the error message in the program shows different phone number format from the User Guide, which causes confusion to the user on the valid phone number format to use.

Screenshot 2024-04-19 at 4.57.02 PM.png

soc-se-bot commented 5 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

PHONE_NUMBER format does not behave as the UG

The UG stated that phone number must follow the standard Singapore telephone numbers (i.e. 9XXXXXXX or 8XXXXXXX). However, adding phone numbers with format different from those mentioned is still allowed.

image.png


[original: nus-cs2103-AY2324S2/pe-interim#4181] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [I believe that this is not a duplicated issue as the issue being reported is regarding Incorrect/ Irrelevant Error Message being shown in the application itself. While the duplicate of another issue is about successful insertion of phone number. ]


## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** [I believe that this issue is considered FeatureFlaw. This issue does against the product design and having project constraint violations where the team specified that the application follows standard Singapore telephone number but having a contradiction on the message box of the application. From a user point of view, the feature of the application is working differently compared to the User Guide. ![Screenshot 2024-04-23 at 2.49.24 PM.png](https://raw.githubusercontent.com/choowengyan/pe/main/files/f86ef3bd-5927-42f4-aefc-4898bf8225fb.png) ]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** [I believe that this issue is categorised into Medium. This is because incorrect error message will give a false information to the user and it is not working as what the application is expected to. For example, the user uses the application straight without reading the User Guide and thought that as long as the phone number inserted is more than 3 digits long such as phone number from Malaysia, China or India, would be a valid one. **However, the application only serves Singapore Phone Number.** Hence, in a scenario where the user need to contact the person in the list, user would not be able to reach out to them as he/she is actually calling people from overseas instead of Singapore. Extra changes may imply and causes a lot of trouble to the user where he/she needs to find the correct way to contact the person once again, it is time consuming and not efficient, which violates the purpose of having this application being able to arrange meetings in faster manner. ![Screenshot 2024-04-23 at 2.57.21 PM.png](https://raw.githubusercontent.com/choowengyan/pe/main/files/ed9b458d-7099-4a2c-b4e0-975b851b8a96.png) Screenshot taken from team's User Guide: The application supposed to manage meetings in an efficient manner as stated in the User Guide, but given the issue, it will cause a lot of trouble and it does not really help to manage the tasks faster in any manner. ![Screenshot 2024-04-23 at 2.56.42 PM.png](https://raw.githubusercontent.com/choowengyan/pe/main/files/08932d3b-cbba-489b-81b6-609b852bc941.png) ]