choowengyan / pe

0 stars 0 forks source link

Allow adding invalid Email Address for `add` command #4

Open choowengyan opened 2 months ago

choowengyan commented 2 months ago

According to the screenshot below, the program allows adding invalid email address that does not follow the format of valid email address as stated in the UG.

For example, the program allow input of email address such as johnd@we without .com (which violates the standard email address format)

Screenshot 2024-04-19 at 4.23.56 PM.png

As shown in the program, error message did also mention that the domain should be separated by periods. However, the program did allow user to input domain without .com (which is invalid in real-world scenario) Screenshot 2024-04-19 at 4.29.33 PM.png

nus-se-bot commented 2 months ago

Team's Response

Thanks for your report, but johnd@we is a valid email address according to the email address formatting standards, and the domain of an email address can be a local domain name with no top level domain.

Check out this stack overflow article that show many examples of how emails without a dot are still valid. Screenshot 2024-04-20 at 12.48.55 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [According to the team's response, I believe that the email address being tested (johnd@we) is still invalid according to the reasonings below:

  1. According to the team's User Guide, it says that email address MUST follow standard email address format, with an example below clearly showing that the team's definition of standard email address contains 3 parts (in italic) separated by @ and . : username@domain.com Screenshot 2024-04-23 at 2.08.13 PM.png

  2. As shown in the bug report given above, the team has mentioned about the format of email address and its constraint in the application (specifically in the message box of the app), especially stated in point 2 where the domain labels is separated by periods. However, the tested email address domain is not separated by periods at all. This has clearly contradict with team's response on the definition of standard email address format.

  1. This is followed by a '@' and then a domain name. The domain name is made up of domain labels separated by periods.

image.png

  1. As shown in the screenshot below, it is clearly that the email address being stated is NOT a valid email address (tested using Gmail) Screenshot 2024-04-23 at 2.17.02 PM.png

    ]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** [I believe that the severity of this issue can be considered as Medium, as it causes inconvenience to the user. Given a scenario where all the email address inputted in the application are not correctly checked (E.g. all emails inserted are without `.com`) , and when there is a need to bulk sending emails to the person in the list, all the emails sent will be bounced back, causing significant inconvenience to the user due to lack of checking for a **valid** email address format. ![Screenshot 2024-04-23 at 2.20.25 PM.png](https://raw.githubusercontent.com/choowengyan/pe/main/files/2c17f280-766d-4db0-8c7c-688610fabb75.png) Email address is considered a very important field/ information for the context of this application as it is used to manage meetings and it will be the main channel to contact the person. Hence, I believe that solving this issue will make a significant improvement to the application. Screenshot below taken from teams's User Guide. ![Screenshot 2024-04-23 at 2.25.19 PM.png](https://raw.githubusercontent.com/choowengyan/pe/main/files/7d528f37-0249-4c15-8cc9-64ec86962411.png) ]