choowengyan / pe

0 stars 0 forks source link

Allow adding duplicated person with extra white spaces #7

Open choowengyan opened 2 months ago

choowengyan commented 2 months ago

As shown in the screenshot below, the program allows adding the same person Betsy Crowe (Client index 14 & 15) where Client index 15 contains extra white spaces in between the name where they are likely to be the same person. Similarly, extra white space (e.g., the user typed an extra space between the two names) is unlikely to mean they are two different persons.

Typically, it is best if you can give a warning in such near match cases so that the user can make the final decision.

Screenshot 2024-04-19 at 4.42.52 PM.png

soc-pe-bot commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Name is case sensitive

When adding a new client, clients with the same name but different capitalizations are considered as different people. The user guide specifically mentioned that duplicate clients with the same name should not be allowed, but they should at least restrict this behavior or give an error message when given with such an input

Steps to reproduce:

  1. add n/Betsy Crowe t/friend e/betsycrowe@example.com a/Newgate Prison p/1234567 t/criminal
  2. add n/Betsy crowe t/friend e/betsycrowe@example.com a/Newgate Prison p/1234567 t/criminal

[original: nus-cs2103-AY2324S2/pe-interim#4091] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [I believe that case sensitivity and having extra whitespaces in names are two different issues. ]