choowengyan / pe

0 stars 0 forks source link

Incorrect Case Sensitivity for Name in `edit` command #8

Open choowengyan opened 2 months ago

choowengyan commented 2 months ago

As shown in the screenshot below, the program allows editing user with the same name (Client Index 13 and 15) but different case sensitivity (Eg David Lee in Client index 13 and David lee in Client Index 15) where they are very likely to be the same person.

In real-world scenario, as person's name is not case sensitive, they shouldn't be case sensitive in the app either.

Screenshot 2024-04-19 at 4.46.31 PM.png

soc-pe-bot commented 2 months ago

Team's Response

As fixing this issue would entail fixing the case sensitivity for the name in the add command as well, this has been indicated as a duplicate.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Name is case sensitive

When adding a new client, clients with the same name but different capitalizations are considered as different people. The user guide specifically mentioned that duplicate clients with the same name should not be allowed, but they should at least restrict this behavior or give an error message when given with such an input

Steps to reproduce:

  1. add n/Betsy Crowe t/friend e/betsycrowe@example.com a/Newgate Prison p/1234567 t/criminal
  2. add n/Betsy crowe t/friend e/betsycrowe@example.com a/Newgate Prison p/1234567 t/criminal

[original: nus-cs2103-AY2324S2/pe-interim#4091] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]