fix validation logic of cropping

chooyan-eng / crop_your_image

A flutter plugin which provides Crop Widget for cropping images.

https://pub.dev/packages/crop_your_image

Apache License 2.0

163 stars 139 forks source link

fix validation logic of cropping #143

Closed chooyan-eng closed 9 months ago

chooyan-eng commented 9 months ago

dx and dy of bottomRight sometimes exceed the image.width and image.height slightly, such like 640.00004 when the image size is 640, and causes InvalidRectError.

This fix includes 2 enhancements below.

fix comparison from double to int.
use .negative rather than < 0

This PR fixes #142

kaurin-liebrecht-haas commented 6 months ago

Hey! I am facing the same issue for topLeft. Getting topLeft.dy.isNegative = -5.211189645992988e-13 which must be a floating point error