search

chop-dbhi / avocado

Metadata APIs for Django
http://avocado.harvest.io
Other
41 stars 10 forks source link

Modify *get_result_rows to accept kwargs for QueryProcessor #323

Closed murphyke closed 8 years ago

murphyke commented 8 years ago

See https://github.com/chop-dbhi/serrano/issues/295. When using a custom QueryProcessor to modify queries based on contents of the request object, such as user or session, something like this patch may be required.

murphyke commented 8 years ago

OK; will sign the commit.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 81.458% when pulling 8685bcbf8a3b5d8c9e064ec0a9274632273a5680 on murphyke:async-result-request into ca4439228b66225e3d1667a58b3c22c036a54608 on chop-dbhi:master.

murphyke commented 8 years ago

I see from Byron's comment at https://github.com/chop-dbhi/serrano/issues/295#issuecomment-241092906 that this won't work for the async calls.

bruth commented 8 years ago

Well to be clear, this change does not actually result in the breakage. It still requires the request itself to be passed in by Serrano. Grant it, this is an implicit contract..

murphyke commented 8 years ago

Yes, I meant "won't work when used as I intended".

bruth commented 8 years ago

Good idea.. I am taking a look.

bruth commented 8 years ago

Wrong thread..