search

chop-dbhi / cilantro

Official client for Harvest (http://harvest.research.chop.edu)
http://cilantro.harvest.io
Other
28 stars 8 forks source link

Revert static column header change #691

Closed ryanjohara closed 9 years ago

ryanjohara commented 9 years ago

Fixes #689

Signed-off-by: Ryan O'Hara oharar@email.chop.edu

naegelyd commented 9 years ago

I don't think we need to revert all the changes here. Instead, I think we can fix #689 and keep the pinned-to-top column headers by using less aggressive selectors. For example, here and here. These selectors are too aggressive. They should really only be selecting from the immediate descendants of the header and table respectively.

murphyke commented 9 years ago

I agree that the pinned-to-top column headers are great. However, I think that the fixed-width columns should either be dispensed with or become togglable with a Cilantro setting.

naegelyd commented 9 years ago

Closing in favor of the github generated revert PR(#694).