Wait for context/view save before opening results page

[naegelyd]

Fix #690.

Signed-off-by: Don Naegely naegelyd@gmail.com

[murphyke]

Hi Don, this works great, but it does reveal the fact that it can take a shockingly long time "merely" to save the view and context.

I will obviously accept this change as is, but I think we need an activity indicator here, maybe with text "Preparing saved query".

Aside: this delay is something that will improve greatly as more caching is implemented. For instance, there are 16 duplicate queries each for every field used in the context, e.g.:

SELECT DISTINCT "core_sample"."status" FROM "core_sample" ORDER BY "core_sample"."status" ASC

if core_sample.status is used in the where clause.

See https://gist.github.com/murphyke/dc1daa75bf65c84ce028 for all database queries issued between clicking a saved query and having the context and view be saved.

[murphyke]

@ByronRuth I know you're multitasking, but I'm interested in this making it into a Cilantro release as soon as is feasible, because saved queries frequently return incorrect results, which is preventing us from publicizing some new public saved queries in PCGC.

[bruth]

@murphyke Creating a release now. Note that this does not include #691

[murphyke]

Ah, I need both but may cobble something together temporarily if I have to.

[bruth]

@murphyke @naegelyd was quick, it will contain the revert, just not the sticky header.

[bruth]

@murphyke That is suitable? At least the cells will not appear destroyed.

[murphyke]

Yes, that's fine

[bruth]

@murphyke https://github.com/cbmi/cilantro/releases/tag/2.3.2

[murphyke]

@bruth thx