search

chop-dbhi / cilantro

Official client for Harvest (http://harvest.research.chop.edu)
http://cilantro.harvest.io
Other
28 stars 8 forks source link

Non-viewable concepts can be viewed #706

Closed murphyke closed 10 years ago

murphyke commented 10 years ago

I.e., the concept is non-viewable, but it shows up in the Change Columns dialog and can be added as a results column. A coworker has confirmed this. I first noticed this with fields that have always been non-viewable, so it's not that I forgot to reload the page.

It certainly doesn't happen for all non-viewable concepts, and I'm not sure how to reliably reproduce an example of this, although I've seen it a few times. I've seen it for fields both with and without formatters.

Sorry for such a lame report, but I don't have time to dig into it at the moment and didn't want to forget to report it.

naegelyd commented 10 years ago

Before I begin trying to test this and figure out if there is an actual issue let's run down how the Concepts are put in the change columns window and make sure this isn't something that might be amiss in the admin window.

main.js is responsible for assigning the viewable concepts to the columns dialog. This is done here. The viewable concepts are defined in the concept model here. So, before we do more to chase down possible causes of this issue, can you confirm that the non-viewable concepts also do not have a formatter. The concepts are considered "viewable" if they are explicitly marked viewable in the admin OR if they have a formatter defined on them. This behavior should probably be better documented somewhere if it turns out to be the cause of this issue.

murphyke commented 10 years ago

@naegelyd That must be what we were seeing, my comment about "with or without formatters" notwithstanding. I tried it again and found that it behaves as you describe. However, personally, I wouldn't expect the presence of a formatter to have that effect.