search

chop-dbhi / data-models-service

Service for consuming files in the data models format.
1 stars 1 forks source link

Fix CI/CD bugs #30

Closed gracebrownecodes closed 7 years ago

gracebrownecodes commented 7 years ago

Inform AWS that the container port is 8123. Run built container instead of pulling from old docker hub repo.

Change docker image by basing on Alpine Linux and copying the build binary into the image instead of building inside of the image. This requires the use of the new make docker command.

Fixes #24

Signed-off-by: Aaron Browne aaron0browne@gmail.com

gracebrownecodes commented 7 years ago

@bruth Opening a new PR from this branch. CircleCI still isn't working, so I'm going to talk to our DevOps team (!!!) about moving to our own hosted Jenkins CI. But, the docker build improvements on this branch are worth merging, imo.

gracebrownecodes commented 7 years ago

Actually, @bruth, hold on that. I'm working with @tjrivera and Will on a new and simplified CI solution.

bruth commented 7 years ago

Any update on this?

willstruebing commented 7 years ago

@bruth @aaron0browne I am waiting on permissions in the new AWS accounts. Once that is done, I will be done with this within a day or two. The automation aspect is done, will just need to update the DNS

gracebrownecodes commented 7 years ago

Superseded by #31. Closing.