chop-dbhi / data-models

Collection of various biomedical data models in parseable formats.
https://data-models-service.research.chop.edu
28 stars 8 forks source link

Standardize field attributes #123

Open gracebrownecodes opened 8 years ago

gracebrownecodes commented 8 years ago

The json-table-schema spec gives the following attributes:

and the following constraint attributes:

I think to this we should add:

gracebrownecodes commented 8 years ago

I think it's also worth keeping the default attribute.

murphyke commented 8 years ago

Re: precision, scale, and maxLength, I think it would be better to add separate precision and scale attributes. If you co-opt maxLength, it seems like it should be for precision, since that's the total number of digits, although doing so may cause confusion because people will not know if the decimal point is included in the "length".

gracebrownecodes commented 8 years ago

Yeah, I got precision and scale confused, obviously. What terrible names. Anyway, I think you're right that we shouldn't co-opt maxLength for this purpose and instead should use separate attributes.

murphyke commented 8 years ago

They are truly horrible names; I have to look them up whenever I have to deal with them.