chop-dbhi / data-models

Collection of various biomedical data models in parseable formats.
https://data-models-service.research.chop.edu
28 stars 8 forks source link

OHDSI added new column in drug_strength, denominator value #134

Closed burrowse closed 8 years ago

burrowse commented 8 years ago

While building the v2.2 vocab snapshot it was discovered that OHDSI created a new column in the drug_strength table...this will need to be updated in our DDL generation scripts.

See reference code, this is not updated as yet on their wiki https://github.com/OHDSI/Vocabulary-v5.0/blob/41b41adf38297c36c6fbe1cc53178f327c31099c/working/DevV5_DDL.sql

gracebrownecodes commented 8 years ago

Haha, I didn't see that you were tackling this before I did. I guess it's better than having no one working on it...

gracebrownecodes commented 8 years ago

Does my PR look good to you?

burrowse commented 8 years ago

Thanks! Looks good.