search

chop-dbhi / data-models

Collection of various biomedical data models in parseable formats.
https://data-models-service.research.chop.edu
27 stars 8 forks source link

Add concept table to PEDSnet models #14

Closed bruth closed 9 years ago

gracebrownecodes commented 9 years ago

My understanding of the PEDSnet data model is that it specifically relies on the OMOP vocabulary tables (of which concept is one).

bruth commented 9 years ago

Right, my pending PR includes both of the concept and vocabulary tables. I saw it from the standpoint of following the reference fields in the other parts of the data model.

gracebrownecodes commented 9 years ago

I can see multiple ways of expressing the reliance of pedsnet on omop vocabulary tables, but I think in the long term it makes the most sense to include the concept tables in both CDMs, so I support this step in that direction.