chop-dbhi / data-models

Collection of various biomedical data models in parseable formats.
https://data-models-service.research.chop.edu
28 stars 8 forks source link

Remove NOT NULL constraint from two vocab fields #144

Closed murphyke closed 8 years ago

murphyke commented 8 years ago

Remove NOT NULL for vocabulary_reference and vocabulary_version in vocabulary. Fixes #143.

gracebrownecodes commented 8 years ago

Rebase on master to include Python upgrade in CircleCI and include a version bump in the PEDSnet models.csv and it looks good to go.

murphyke commented 8 years ago

OK, I will bump the release_serial value since that seems to be popular.

Since semantic versioning isn't really applicable to data models, it is fair for the interpretation to be left up to each data model community. However, it might be helpful to come up with some suggestions about when to bump the various version components.

gracebrownecodes commented 8 years ago

I agree with all points.