search

chop-dbhi / data-models

Collection of various biomedical data models in parseable formats.
https://data-models-service.research.chop.edu
28 stars 8 forks source link

Issue 257 #146

Closed burrowse closed 8 years ago

burrowse commented 8 years ago

Request to make the change to add death_cause_id to the death table as the primary key

gracebrownecodes commented 8 years ago

Shouldn't this be a new data model version if we are adding a new field? i.e.: v2.3? Also, you should add an entry in the not nulls file for this PK.

burrowse commented 8 years ago

@aaron0browne Yeah, I wanted to check in with you about that. I'll make the changes for a new version then.

gracebrownecodes commented 8 years ago

Great!

burrowse commented 8 years ago

@aaron0browne Will open a new pull request.