Add PEDSnet v2.4 model specification

chop-dbhi / data-models

Collection of various biomedical data models in parseable formats.

https://data-models-service.research.chop.edu

28 stars 8 forks source link

Add PEDSnet v2.4 model specification #152

Closed burrowse closed 7 years ago

murphyke commented 7 years ago

Just for posterity, we sorted through various issues out-of-band. One thing that came up is that the primary data models service could stand to publish the results of its validation, and I'll make a ticket for it.

I diffed the DDL between 2.3 and 2.4, and the differences look sane in general.

@burrowse There is just one small issue remaining: can you add indexes.csv entries for the adt_occurrence foreign key columns and any columns that would be likely to be used in query conditions?

burrowse commented 7 years ago

Sure @murphyke. I've added a few indexes to the table. Please review and advise

murphyke commented 7 years ago

LGTM. Merging.