CI configuration - Githubissues

chop-dbhi / data-models

Collection of various biomedical data models in parseable formats.

https://data-models-service.research.chop.edu

28 stars 8 forks source link

CI configuration #163

Closed murphyke closed 7 years ago

murphyke commented 7 years ago

@aaron0browne For fork PRs to be tested, I think the following changes should be made in the CircleCI advanced settings:

"Build forked pull requests" => "On"
"Pass secrets to builds from forked pull requests" => "Off"

Can you do that? I don't think I have the permissions. The only chop-dbhi repo that I can see from CircleCI is grin_harvest.

gracebrownecodes commented 7 years ago

Done, but I'm now remembering a reason #157 languished for so long, which is that I think some parts of the CI might need those secrets? Maybe its just the deployment step?

murphyke commented 7 years ago

https://circleci.com/docs/1.0/fork-pr-builds/. I think it's only deployment that would need the CircleCI UI-configured secrets, because the configuration worked for me when I hooked CircleCI up to a fork of data-models (and then PR'd a fork of that).

gracebrownecodes commented 7 years ago

Great!