chop-dbhi / dataexpress

[NOT MAINTAINED] DataExpress is a simple, Scala-based cross database ETL toolkit supporting Postgres, MySql, Oracle, SQLServer, and Sqlite
http://dataexpress.research.chop.edu
BSD 2-Clause "Simplified" License
72 stars 9 forks source link

Make SQL method semantics consistent #40

Open mitalia opened 11 years ago

mitalia commented 11 years ago

In general we have a mix of semantics in use when sql methods are called. They should be unified as follows:

If a method can return something (e.g. a count, resultset, etc...) it should return an Option[Type]. If the method merely performs a task which may or may not succeed, it should not return anything and should instead rely on exceptions for proper error handling. In cases where the underlying JDBC driver returns some true/false that must be checked, this should be promoted to a try/catch exception mechanism.