search

chop-dbhi / ehb-datasources

datasource drivers, e.g. REDCap and Nautilus, that can be plugged into the Biorepository Portal
BSD 2-Clause "Simplified" License
2 stars 2 forks source link

Add today & date-picker widgets and manual date validator #15

Closed r3m0chop closed 8 years ago

r3m0chop commented 8 years ago

@tjrivera and @alexfelmeister - there isn't yet an issue or develop branch on this public repo, and I don't yet have permissions, so feel free to consider either adding such a branch for this PR, or pulling it straight into master as per the current PR request... whatever works for you. Fixes #14.

tjrivera commented 8 years ago

thanks @r3m0chop. This project has a small suite of tests to test the expected output of the different drivers. Can you update the test_regular_srf test? Its located here. After installing the nose package included in the requirements.txt you can run nosetests in the root of the project to run the suite. The diff between the tested string and the output of the driver may be difficult to diff. I'll sometimes add a one liner to the driver temporarily to output the generated html out to an external file to then bring into the test. YMMV

tjrivera commented 8 years ago

This otherwise looks and works great, thanks for your work on this!

r3m0chop commented 8 years ago

@tjrivera - nosetest recommendations greatly appreciated, thank you.