search

chop-dbhi / ehb-datasources

datasource drivers, e.g. REDCap and Nautilus, that can be plugged into the Biorepository Portal
BSD 2-Clause "Simplified" License
2 stars 2 forks source link

When retrieving Nautilus samples improve error message #52

Open seg1129 opened 5 years ago

seg1129 commented 5 years ago

when there is an error getting nautilus samples the error message in the code below should be updated to provide additional possibilities as to why there was an error.

@alexfelmeister can you provide better verbiage for this message, "Zero samples returned, validate user has access to protocol in nautilus."

https://github.com/chop-dbhi/ehb-datasources/blob/d38c2ae36df471bfd26d055efd073af3ea58cac7/ehb_datasources/drivers/nautilus/driver.py#L153

alexfelmeister commented 5 years ago

What do you think?

WARNING: Information for Sample Kit <record_id> was not returned from the Laboratory System.
Please contact eigsupport@email.chop.edu to determine if this is one of the following issues:
-   Your Laboratory Information Management System credentials are out of date.
-   Correct access from the CHOP Biorepository Resource Center to access information about <record_id>.
-   You entered the incorrect record.
-   
The association of <patient_id> and <record_id> was recorded in the honest broker on <create_date>. When the above issue is resolved, this warning will not appear.
seg1129 commented 5 years ago

Looks good to me. The only variables i'm not sure i'll be able to get is '' and ''. I have to take a look to see what is being passed in from kwargs.