Broken Query navigation

chop-dbhi / omop_harvest

OMOP CDMV4 data model with OSIM2 data in Harvest

https://eig.research.chop.edu/omop/

Other

5 stars 3 forks source link

Broken Query navigation #37

Closed hassanNS closed 9 years ago

hassanNS commented 10 years ago

If you are logged in and navigate back to the home welcome page and then try to navigate back to the query page, weird things happen. Steps to recreate: 1) login to a omop_harvest session. 2) Click on the 'PDSNet Harvest' navigation tag on the top tab. 3) Click on the blue 'Explore Omop Harvest' button.

You will see this broken

hassanNS commented 10 years ago

I believe the issue might be in the way the routes are set up.

gracebrownecodes commented 10 years ago

I've confirmed this and labelled as a bug. @hassanNS Can you look into a fix?

hassanNS commented 10 years ago

will do

hassanNS commented 10 years ago

Just a suggestion. If a user is logged in, do we want them to navigate back to the welcome page?

gracebrownecodes commented 10 years ago

Not clear what you mean. I can imagine several situations:

User is not logged in and logs in: redirect to query page
User is logged in and on the query/results/workspace page: we want to allow them to navigate back to the welcome page (by clicking the PEDSnet Harvest header link)
User has logged in and closed the page, but session is still active when they re-open the site: landing on the welcome page is fine, but landing on the query page would be fine too

Were you thinking about one of those cases, or another one?

hassanNS commented 10 years ago

The second bullet point. I guess it's because I haven't seen a harvest app that has a welcome page and a login (only worked w/ varify and openmrs so far)

hassanNS commented 10 years ago

I think the fix for this should be that the PEDSnet title should disappear when the user logs in

hassanNS commented 10 years ago

workspace/query/results are not links but the title is a link that changes the html of the page which is why this problem is occuring

naegelyd commented 9 years ago

@hassanNS Is this still an issue? I just bumped this tot he latest version of Cilantro.

hassanNS commented 9 years ago

@naegelyd yeah last time I tested. I think the problem is with having a landing and a login page on the same application.

gracebrownecodes commented 9 years ago

Don't worry @hassanNS @naegelyd I'm still owning the currently broken state of this repo and under heavy refactoring. I'm ripping out the registration and login entirely and updating to the latest stack components, so I presume that will take care of the issue. Either way, the observations in this issue likely won't apply, so I'll close.