chop-dbhi / prometheus-sql

Service that exposes Prometheus metrics for a SQL result set.
BSD 2-Clause "Simplified" License
202 stars 55 forks source link

Replace ADD in Dockerfile to follow Docker best practices #17

Closed haxorof closed 7 years ago

haxorof commented 7 years ago

ADD today fetches the release here from Github but according to Docker best practices this kind of use of ADD shall be avoided:

Construct similar to this shall be used instead:

RUN mkdir -p /usr/src/things \
    && curl -SL http://example.com/big.tar.xz \
    | tar -xJC /usr/src/things \
    && make -C /usr/src/things all