search

chop-dbhi / prometheus-sql

Service that exposes Prometheus metrics for a SQL result set.
BSD 2-Clause "Simplified" License
202 stars 55 forks source link

Error process #8

Closed wangyanbn closed 7 years ago

wangyanbn commented 7 years ago

Add error process logic, which can be used as a simple and general database health checker. Add error-value in queries.yml. The default error value is null. if not null, when query has error, we will use this value to indicate an error has occured.

haxorof commented 7 years ago

A minor comment from me would be to change error-value to value-on-error. That would fit more if this is later extended to also handle default values to replace null values. @bruth What do you think?

bruth commented 7 years ago

@haxorof Any other thoughts? If not, feel free to merge.

bruth commented 7 years ago

Squash and merge, specifically.. keep the history clean.