chop-dbhi / prometheus-sql

Service that exposes Prometheus metrics for a SQL result set.
BSD 2-Clause "Simplified" License
202 stars 55 forks source link

QQ: Is 'latest' docker image stable? #85

Closed mainiak closed 3 years ago

mainiak commented 3 years ago

Hello.

Looking at https://hub.docker.com/r/dbhi/prometheus-sql/tags?page=1&ordering=last_updated I am not sure if docker image with tag 'latest' is beta / release candidate / or just plain release.

image

Can you please clarify what is intended purpose for 'latest' version from your point of view?

Thank you in advance for your reply.

haxorof commented 3 years ago

Hi @mainiak!

I understand you confusion and I do not have insight into how the Docker build is setup on Docker Hub due to access. I assume "latest" currently means "master".

@bruth - Could you make sure the following build rules are configured in Docker Hub for prometheus-sql:

Source Type = Branch Source = master Docker Tag = master Dockerfile location = Dockerfile Build Context = /

Source Type = Tag Source = /^[0-9.]+$/ Docker Tag = latest Dockerfile location = Dockerfile Build Context = /

Source Type = Tag Source = /^[0-9.]+$/ Docker Tag = {sourceref} Dockerfile location = Dockerfile Build Context = /

Having the above configuration will ensure at least latest tagged build will trigger the build of latest. And then master will then be latest commit on master.

Cheers!

bruth commented 3 years ago

I am not sure why Docker Hub was showing that, but this is what I see today.

Screen Shot 2021-06-22 at 9 26 40 PM
haxorof commented 3 years ago

Hi @bruth,

I did a new bug fix release where quickly fixed two bugs and bumped some version on dependencies, added a changelog also: https://www.github.com/chop-dbhi/prometheus-sql/tree/master/CHANGELOG.md

To make it better around what is built could you check the Docker hub build configuration and maybe set it as I suggested in previous post?

bruth commented 3 years ago

@haxorof Updated the automated builds.

Screen Shot 2021-07-06 at 7 23 30 AM
haxorof commented 3 years ago

From now on: