Provide local CSS when external CDN fails

chop-dbhi / varify

Clinical DNA Sequencing Analysis and Data Warehouse

BSD 2-Clause "Simplified" License

24 stars 8 forks source link

Provide local CSS when external CDN fails #362

Closed ryanjohara closed 10 years ago

ryanjohara commented 10 years ago

Fixes #352

Signed-off-by: Ryan O'Hara oharar@email.chop.edu

coveralls commented 10 years ago

Coverage remained the same when pulling e34bc9196599853db58afd120491eb5002f35477 on ryanjohara:issue-239 into b74c7805d5bc30a4d57c327a03cd2d92fabf9902 on cbmi:master.

naegelyd commented 10 years ago

Please rebase this on master. I had to muck with the revision history because I apparently can't increment versions today....

naegelyd commented 10 years ago

@ryanjohara Have you tested if the fallbacks work by giving a bad path for bootstrap or something to make sure that the local copy gets used?

ryanjohara commented 10 years ago

Yes, I tested with an invalid CDN URL before I committed.

naegelyd commented 10 years ago

Great, just wanted to be sure