search

choptop84 / abyssbox-source

A modification of Ultrabox made by choptop84
MIT License
4 stars 2 forks source link

Note recording broken for custom scale #5

Open evguu opened 2 months ago

evguu commented 2 months ago

Custom scale requires special handling, which was forgotten in some places. Examples:

https://github.com/choptop84/abyssbox-source/blob/1b84f6ffb52184879834680d3527c091fbae4be2/editor/RecordingSetupPrompt.ts#L155 Missing handling causes incorrect note recording prompt layout for custom scale.

https://github.com/choptop84/abyssbox-source/blob/1b84f6ffb52184879834680d3527c091fbae4be2/editor/KeyboardLayout.ts#L28 Missing handling causes note recording to always use the default setup of the scale, ignoring what the user has set.

choptop84 commented 1 month ago

Both of these files are nearly identical to UltraBox, so either the issue is found elsewhere or UltraBox also has this issue