choreonoid / choreonoid_ros

ROS package to use Choreonoid as a ROS node
12 stars 12 forks source link

Modification of sensor data publisher #11

Open Hiroaki-Masuzawa opened 1 year ago

Hiroaki-Masuzawa commented 1 year ago

The following modifications have been changed.

ssr-yuki commented 1 year ago

Thank you. Your suggestions are important.

However, this PR adds/affects multiple features while it includes only one commit. It is difficult for us to discuss, organize, and merge it, with this PR structure.

Could you open one PR for each topic?

Moreover, we are glad if you format your codes: Choreonoid recommends you to use the Camel case for all variables, use ++i instead of i++ for counters, avoid multiple operations on the same line, etc.

Hiroaki-Masuzawa commented 1 year ago

Thank you for your comment.

I will create 3 separate pull requests, but I created 2 (#12, #13) of them first because there are many conflicts between the pull requests.

I am not familiar enough with the coding standards, so I would appreciate your comments.