search

choreonoid / choreonoid_ros

ROS package to use Choreonoid as a ROS node
12 stars 12 forks source link

Check publisher's conection #12

Closed Hiroaki-Masuzawa closed 1 year ago

Hiroaki-Masuzawa commented 1 year ago

Skip the publishing process when there is no connection.

related to #11.

ssr-yuki commented 1 year ago

Sorry for my late review and Thank you for great contribution. I have verified that this PR prevents BodyROS from publishing unnecessary topics and reduces computational and communicational costs.

Only one thing I want you about this PR is inserting spaces in evaluation equations as publisher.getNumSubscribers() == 0. Could you apply this?

Hiroaki-Masuzawa commented 1 year ago

Thank you for checking. I have committed to the modified version.