search

choreonoid / choreonoid_ros

ROS package to use Choreonoid as a ROS node
12 stars 12 forks source link

add propertiy: publishJointState for on/off publishing joint_state #14

Closed YoheiKakiuchi closed 1 year ago

YoheiKakiuchi commented 1 year ago

By This PR, a user can stop to publish joint_state by BodyROSItem. This PR do not change default behavior.

joint_state can be published using joint_state_controller through ros_control. http://wiki.ros.org/joint_state_controller

ssr-yuki commented 1 year ago

Thank you for your proposal. The added property looks good and important.

I am just wondering if you have another candidate of the name of the flag managing publishing joint states. The current name publishJointState starts with a verb and such a name is not suitable for a variable name; it is often used for function names.

I have no good idea now, but I think we should rename it into publish*ing*JointState*s*, at least.

YoheiKakiuchi commented 1 year ago

Following are the candidates that I think about.

I prefer 'publish_joint_state', because it is the shortest name.

ssr-yuki commented 1 year ago

How about using joint_state_publication / jointStatePublication ?

YoheiKakiuchi commented 1 year ago

How about using joint_state_publication / jointStatePublication ?

I renamed to joint_state_publication / jointStatePublication.