choreonoid / choreonoid_ros

ROS package to use Choreonoid as a ROS node
12 stars 12 forks source link

FIX: install launch file #16

Closed YoheiKakiuchi closed 1 year ago

YoheiKakiuchi commented 1 year ago

Install launch file for using like below.

roslaunch choreonoid_ros launch/choreonoid.launch
ssr-yuki commented 1 year ago

In my understanding, installation of launch files is meaningless, while it is described in the document of catkin.

According to the official document of roslaunch, the provided basic usage of roslaunch is either of

With the former syntax, roslaunch automatically finds a file with the matching name inside the specified package. Installed directories are excluded from the search, and the syntax does not accept relative paths.

This is why we had removed the launch file installation before (you can see the commit).

Even after I apply this PR, the command roslaunch choreonoid_ros launch/choreonoid.launch causes the following error in my environment (Ubuntu 20.04 / ROS1 Noetic).

RLException: [launch/choreonoid.launch] is neither a launch file in package [choreonoid_ros] nor is [choreonoid_ros] a launch file name
The traceback for the exception was written to the log file

If the command works well in your environment, please tell me how to reproduce it. Thanks.

YoheiKakiuchi commented 1 year ago

I'm sorry for the lack of explanation.

I am talking about installing to "Install space". Using catkin config --install

In that case, we can not use files by ROS-manner that do not explicitly describe where they are to be installed. ( we may remove directories devel, log and src in catkin_ws. )

ssr-yuki commented 1 year ago

I understand you want to install chorenoid_ros into the install space with catkin command. It is Ok.

I would just like to ask you the situation the following command works well.

roslaunch choreonoid_ros launch/choreonoid.launch

Could you show me an example usage or any documents on this? Thanks.

YoheiKakiuchi commented 1 year ago

This is a example of using choreonoid.launch

https://github.com/IRSL-tut/irsl_choreonoid_ros/blob/main/launch/sim_robot.launch#L10-L11

It is not using at command-line, but the key point is that I would not like to use absolute path.

ssr-yuki commented 1 year ago

Ok. Could you check if my understanding summarized as follows is correct, please?

YoheiKakiuchi commented 1 year ago

They are correct.

ssr-yuki commented 1 year ago

Good. Thank you.