search

choreonoid / choreonoid_ros

ROS package to use Choreonoid as a ROS node
12 stars 12 forks source link

Fix installation conditions of 'launch' files with catkin #23

Open ssr-yuki opened 4 months ago

ssr-yuki commented 4 months ago

This PR resolves #22 .

To guarantee the requirements discussed in #16 , this PR adds an additional condition to install the launch directory: choreonoid_ros installs the directory only if the destination path ends with install, such as ~/catkin_ws/install.

In fact, this is an ad hoc bug fix, but I don't have any other ideas at the moment.

FYI: the following document provides the list of variables we can utilise in CMake: http://docs.ros.org/en/melodic/api/catkin/html/user_guide/variables.html

ssr-yuki commented 4 months ago

@YoheiKakiuchi Could you check if this PR affects your software please? All suggestions are welcome.

HansRobo commented 4 months ago

I made this PR ready for review, with @ssr-yuki 's consent in another chat tool.