chorhatarahuduketuri / gc

GalacticConquest
0 stars 0 forks source link

Fog of war enhancements #104

Closed adrianlshaw closed 5 years ago

adrianlshaw commented 5 years ago

Fixes #75 and #9

adrianlshaw commented 5 years ago

By the way, @chorhatarahuduketuri, no changes to the AI have been made to limit its visibility. Something for the future.

chorhatarahuduketuri commented 5 years ago

By the way, @chorhatarahuduketuri, no changes to the AI have been made to limit its visibility. Something for the future.

Noted.

adrianlshaw commented 5 years ago

This PR was working well when it was submitted. However, with the recent rebase on master it seems that the onDraw method is now under a lot of pressure - to the point that it is now skipping frames. Will investigate how to improve it with a profiler and such tools.

adrianlshaw commented 5 years ago

Fixed the sluggish performance. @chorhatarahuduketuri can you review?

adrianlshaw commented 5 years ago

Here is a screenshot of what it looks like. Notice the clipped ship labels which have been fixed in a separate PR (#106).

image
adrianlshaw commented 5 years ago

@chorhatarahuduketuri please pull latest commit and test again

adrianlshaw commented 5 years ago

Btw if you decide to merge I suggest squashing all the commits using the "squash and merge" button.