chorhatarahuduketuri / gc

GalacticConquest
0 stars 0 forks source link

Code styling #17

Closed chorhatarahuduketuri closed 5 years ago

chorhatarahuduketuri commented 6 years ago

I think we should use Android Studios (Intellijs) default code style, and autoformat all files before committing.

Reasons: 1) This makes formatting very easy for the coder and very consistent over the entire project. 2) If it needs to be changed for any reason, the project's default code style can be added to git so that it is instantly universal and there is no extra difficulty for anyone in remembering or implementing it. 3) It means that when someone's changing one line in a file, there aren't a load of other line changes being committed which are only whitespace.

chorhatarahuduketuri commented 6 years ago

I think we should decide on some default, automatable code style, so that we don't continue to encounter whitespace code changes in git (I do everytime I autoformat because my IDE is set to use tabs and there are a lot of spaces around).

I prefer tabs, but don't really care so long as my autoformat of a three char change doesn't modify 300 lines in GalaxyView.java.

chorhatarahuduketuri commented 6 years ago

Ref: #39

chorhatarahuduketuri commented 5 years ago

This is complete now. Closing.