search

chorhatarahuduketuri / gc

GalacticConquest
0 stars 0 forks source link

Refactor: moved unit action code to mechanics pkg #37

Closed chorhatarahuduketuri closed 6 years ago

chorhatarahuduketuri commented 6 years ago

Both the moved methods are static, which I'm not sure about, and would welcome input on.

I've written several new methods in the Unit.java class that turn it inot nothing more than a data store about the unit. There is nothing in there but fancy getters and setters.

Incidentally I was thinking about adding a unit range variable, but decided that units that move >1 sector per turn aren't necessary for the MVP.

adrianlshaw commented 6 years ago

No complaints. I've also tested it and nothing seems broken.

Incidentally I was thinking about adding a unit range variable, but decided that units that move >1 sector per turn aren't necessary for the MVP.

Aligns with my thoughts on the matter.

Both the moved methods are static, which I'm not sure about, and would welcome input on.

It seems adequate as a means to keeping the code more concise, organised and readable.