search

chorhatarahuduketuri / gc

GalacticConquest
0 stars 0 forks source link

GalaxyView.java needs cleaning up #43

Closed chorhatarahuduketuri closed 6 years ago

chorhatarahuduketuri commented 6 years ago

We've been casually adding things to GalaxyView.java in an unplanned way, and it's gotten to be quite a mess, particularly with passing object references around (this has only become such a significant issue due to the recent refactoring).

This class needs to be tidied up and access to fields in other classes and objects restricted via getter/setter methods and the narrowest access scope possible (private by default).

adrianlshaw commented 6 years ago

Couldn't agree more, it's been on my mind.

chorhatarahuduketuri commented 6 years ago

Has this been completed @adrianlshaw ?

adrianlshaw commented 6 years ago

I think we’ve done what’s possible for now. If it becomes a problem again then let’s re-open the issue.