chorhatarahuduketuri / gc

GalacticConquest
0 stars 0 forks source link

The code is way too complicated to test #57

Open chorhatarahuduketuri opened 5 years ago

chorhatarahuduketuri commented 5 years ago

I realise the title of this issue is technically incorrect.

Practically it is correct. Almost every method that isn't a getter/setter effectively requires integration level tests, and complex mocks.

I worry that if we leave it as it is that testing will not happen due to the difficulty of doing so. The only alternative I can come up with right now is a redesign of the code to better accommodate testing. That would be a big thing. It would slow down development in a boring way. I'm not sure of the objectives of doing so, as I haven't considered all the code requirements. I may be worrying too much due to to much caffeine.

adrianlshaw commented 5 years ago

When we had the face-to-face discussion I found it difficult to imagine testing the current codebase with anything other than complex mocks...