Prepare for mcollective::service removal

choria-legacy / mcollective-choria

Distribution of plugins for MCollective as found in Puppet 6

Apache License 2.0

56 stars 24 forks source link

Prepare for mcollective::service removal #638

Closed smortex closed 3 years ago

smortex commented 3 years ago

The mcollective::service class is being removed from the mcollective module https://github.com/choria-io/puppet-mcollective/pull/276.

Some adjustments are required in this repository to cope with it.

[x] ~~#639 Workaround for unbreaking discovery~~ (abandoned)
[x] #640 Allow discovery with choria::service
[x] https://github.com/choria-io/puppet-mcollective/pull/277 Revert server facts removal

ripienaar commented 3 years ago

Hmm, this is not good, will need to make a plan with that - I will probably have to make the server facts work again or write a new fact that picks this up from choria somehow.

Need to have a thing, for now I'll merge the one that just makes it work again and keep this open

ripienaar commented 3 years ago

good stuff

ripienaar commented 3 years ago

@smortex anything else here or can i close this one?

smortex commented 3 years ago

I think we are good. Thanks!